hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Syed Albiz" <s.s.al...@gmail.com>
Subject Re: Review Request: HIVE-2156: Improve Execution Error Messages
Date Thu, 11 Aug 2011 01:07:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/777/
-----------------------------------------------------------

(Updated 2011-08-11 01:07:35.822886)


Review request for hive and John Sichi.


Changes
-------

The previous patch was failing as I generated it using '-Doverwrite=true', and minimr_broken_pipe.q
was being written over twice. I have fixed the patch to exclude minimr_broken_pipe.q from
the regular TestNegativeCliDriver test run, and also updated the diff ignores to prevent the
TestNegativeMinimrCliDriver failure


Summary
-------

- Add local error messages to point to job logs and provide TaskIDs
- Add a timeout to the fetching of task logs and errors


This addresses bug HIVE-2156.
    https://issues.apache.org/jira/browse/HIVE-2156


Diffs (updated)
-----

  build-common.xml 4856c5f 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b46976f 
  conf/hive-default.xml 3a4f833 
  contrib/src/test/results/clientnegative/case_with_row_sequence.q.out 4447c65 
  ql/build.xml 449b47a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1c6f092 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JobDebugger.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java e687b1a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java 3d5e95d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cec0d46 
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 8a50dc6 
  ql/src/test/queries/clientnegative/minimr_broken_pipe.q PRE-CREATION 
  ql/src/test/results/clientnegative/dyn_part3.q.out 5f4df65 
  ql/src/test/results/clientnegative/index_compact_entry_limit.q.out 06437c7 
  ql/src/test/results/clientnegative/index_compact_size_limit.q.out 54f1262 
  ql/src/test/results/clientnegative/minimr_broken_pipe.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/script_broken_pipe1.q.out d33d2cc 
  ql/src/test/results/clientnegative/script_broken_pipe2.q.out afbaa44 
  ql/src/test/results/clientnegative/script_broken_pipe3.q.out fe8f757 
  ql/src/test/results/clientnegative/script_error.q.out c72d780 
  ql/src/test/results/clientnegative/udf_reflect_neg.q.out f2082a3 
  ql/src/test/results/clientnegative/udf_test_error.q.out 5fd9a00 
  ql/src/test/results/clientnegative/udf_test_error_reduce.q.out ddc5e5b 
  ql/src/test/results/clientpositive/auto_join25.q.out 362b2fa 
  ql/src/test/results/clientpositive/mapjoin_hook.q.out acdeefa 
  ql/src/test/templates/TestNegativeCliDriver.vm ec13f79 

Diff: https://reviews.apache.org/r/777/diff


Testing
-------

Tested TestNegativeCliDriver in both local and miniMR mode


Thanks,

Syed


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message