hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong" <kevinwilf...@fb.com>
Subject Review Request: Make performance logging configurable.
Date Wed, 10 Aug 2011 00:14:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1443/
-----------------------------------------------------------

Review request for hive and Ning Zhang.


Summary
-------

I created a new class PerfLogger, which wraps the old functionality of Utilities' PerfLogBegin
and PerfLogBegin methods.  I also added a config variable hive.exec.perf.logger.  The value
of this variable can be changed to point to a subclass of PerfLogger which can customize the
code in PerfLogBegin and PerfLogEnd.


This addresses bug HIVE-2364.
    https://issues.apache.org/jira/browse/HIVE-2364


Diffs
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155439 
  trunk/conf/hive-default.xml 1155439 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1155439 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1155439 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java PRE-CREATION 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 1155439 

Diff: https://reviews.apache.org/r/1443/diff


Testing
-------

I ran the code as it is and made sure it continued to log the performance messages as before.

I also created a subclass of PerfLogger and used its class name as the value of hive.exec.perf.logger,
and verified the subclass's code was run.


Thanks,

Kevin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message