hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan" <jgho...@apache.org>
Subject Re: Review Request: DESCRIBE TABLE causes NPE when hive.cli.print.header=true
Date Mon, 08 Aug 2011 22:42:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1300/
-----------------------------------------------------------

(Updated 2011-08-08 22:42:22.232604)


Review request for hive.


Changes
-------

* Removed star imports in unit test.
* Added test case to integration test.  Call to use default NPEs before patch, succeeds afterwards
* Removed no-op from cli/build.xml to ensure test runs
* Added mockito into cli's ivy.xml.  The top-level ivy.xml doesn't need changed since the
ivy settings aren't inherited.
* Didn't change the split call to tokenize, since it was as is in the original patch.  No
need to introduce unnecessary changes. 


Summary
-------

Commands that don't return a schema cause NPE when print headers is on.


This addresses bug HIVE-2334.
    https://issues.apache.org/jira/browse/HIVE-2334


Diffs (updated)
-----

  cli/build.xml c174b22 
  cli/ivy.xml f272b91 
  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 9fa7bc6 
  cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java PRE-CREATION 
  ivy/libraries.properties af856bd 
  ql/src/test/queries/clientpositive/print_header.q 96380ab 
  ql/src/test/results/clientpositive/print_header.q.out e3946d7 

Diff: https://reviews.apache.org/r/1300/diff


Testing
-------

New unit tests (both positive and negative) and verification on manual cluster.


Thanks,

Jakob


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message