hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <c...@cloudera.com>
Subject Re: Review Request: DESCRIBE TABLE causes NPE when hive.cli.print.header=true
Date Fri, 05 Aug 2011 20:38:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1300/#review1308
-----------------------------------------------------------



cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/1300/#comment2967>

    Might want to consider using StringTokenizer or StreamTokenizer here.



cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java
<https://reviews.apache.org/r/1300/#comment2963>

    cli/build.xml overrides the ant test target with a no-op, so this test is actually not
getting run.



cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java
<https://reviews.apache.org/r/1300/#comment2964>

    Wildcard imports violate the checkstyle guidelines.



cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java
<https://reviews.apache.org/r/1300/#comment2965>

    There's already some very limited test coverage for the hive.cli.print.header feature
in print_header.q. Why not extend this testcase instead of adding a new unit test?



ivy/libraries.properties
<https://reviews.apache.org/r/1300/#comment2966>

    We need to manage this dependency with Ivy. The Hive build currently runs against hadoop-0.20.1,
which does not include mockito-all-1.8.2.jar


- Carl


On 2011-08-05 01:22:01, Jakob Homan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1300/
> -----------------------------------------------------------
> 
> (Updated 2011-08-05 01:22:01)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Commands that don't return a schema cause NPE when print headers is on.
> 
> 
> This addresses bug HIVE-2334.
>     https://issues.apache.org/jira/browse/HIVE-2334
> 
> 
> Diffs
> -----
> 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 9fa7bc6 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java PRE-CREATION 
>   ivy/libraries.properties af856bd 
> 
> Diff: https://reviews.apache.org/r/1300/diff
> 
> 
> Testing
> -------
> 
> New unit tests (both positive and negative) and verification on manual cluster.
> 
> 
> Thanks,
> 
> Jakob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message