hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong" <>
Subject Review Request: HIVE-2347: Added Hadoop Job ID to Task class.
Date Thu, 04 Aug 2011 19:45:20 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for hive and Ning Zhang.


I added a field for the Hadoop Job ID to the Task class.  This will make it accessible to
the Driver and hence to the hooks for logging/debugging purposes.  By including it in the
Task, we only need to check that the type of the task is MAPRED, before getting the job ID.

I considered adding it to several places:

as separate fields in ExecDriver and BlockMergeTask: this would require duplicating code,
require conditions to determine the type of a task and casting to either ExecDriver or BlockMergeTask
in order to get the JobID from them

in the MapRedWork: this would require modifying a field in MapRedWork in the execute function,
and I could not find a precedent for this

This addresses bug HIVE-2347.


  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ 1153966 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ 1153966 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/ 1153966



Ran the TestCliDriver and TestNegativeCliDriver test suites and verified they passed.

Also, created a sample post exec hook which simply logged the JobID for every map reduce task,
and verified it.



  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message