hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan" <jgho...@apache.org>
Subject Re: Review Request: HIVE-2171: Allow custom serdes to set field comments
Date Thu, 04 Aug 2011 00:12:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/790/
-----------------------------------------------------------

(Updated 2011-08-04 00:12:21.542815)


Review request for hive.


Changes
-------

Updated patch based on review comments.


Summary
-------

HIVE-2171: Allow custom serdes to set field comments


This addresses bug HIVE-2171.
    https://issues.apache.org/jira/browse/HIVE-2171


Diffs (updated)
-----

  ivy/libraries.properties af856bd 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java c1fa4e5 
  serde/ivy.xml d6c836a 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
4850601 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
e2fa9db 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java
2947e49 
  serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java
3d5408f 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java
881c3c1 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java
bd42a0c 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
0c8cc42 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
4a934c5 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java
3b26e45 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java 62c3017 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java
76ff736 
  serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java PRE-CREATION

  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java
f139ea5 

Diff: https://reviews.apache.org/r/790/diff


Testing
-------

New unit test and refactor existing unit test.


Thanks,

Jakob


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message