hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Syed Albiz" <s.s.al...@gmail.com>
Subject Re: Review Request: HIVE-2286: ClassCastException when building index with security.authorization turned on
Date Mon, 01 Aug 2011 23:23:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1137/
-----------------------------------------------------------

(Updated 2011-08-01 23:23:46.966525)


Review request for hive, John Sichi and Ning Zhang.


Changes
-------

regenerated patch to avoid noise/clutter in testcase output


Summary
-------

Save the original HiveOperation/commandType when we generate the index builder task and restore
it after we're done generating the task so that the authorization checks make the right decision
when deciding what to do.


This addresses bug HIVE-2286.
    https://issues.apache.org/jira/browse/HIVE-2286


Diffs (updated)
-----

  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 9fa7bc6 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java b278ffe 
  ql/src/test/queries/clientpositive/index_auth.q PRE-CREATION 
  ql/src/test/results/clientnegative/alter_view_failure2.q.out 5915b4f 
  ql/src/test/results/clientnegative/alter_view_failure4.q.out 97d6b18 
  ql/src/test/results/clientnegative/create_or_replace_view1.q.out 97bfa21 
  ql/src/test/results/clientnegative/create_or_replace_view2.q.out 8edac34 
  ql/src/test/results/clientnegative/index_compact_entry_limit.q.out fcb2673 
  ql/src/test/results/clientnegative/index_compact_size_limit.q.out fcb2673 
  ql/src/test/results/clientpositive/create_or_replace_view.q.out fb72971 
  ql/src/test/results/clientpositive/create_view_partitioned.q.out 3b4dd10 
  ql/src/test/results/clientpositive/index_auth.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/index_auto.q.out 8d65f98 
  ql/src/test/results/clientpositive/index_auto_file_format.q.out 194b35e 
  ql/src/test/results/clientpositive/index_auto_multiple.q.out 6b81fc3 
  ql/src/test/results/clientpositive/index_auto_partitioned.q.out b0635db 
  ql/src/test/results/clientpositive/index_auto_unused.q.out 3631bbc 
  ql/src/test/results/clientpositive/index_bitmap.q.out 8f41ce3 
  ql/src/test/results/clientpositive/index_bitmap1.q.out 9f638f5 
  ql/src/test/results/clientpositive/index_bitmap2.q.out e901477 
  ql/src/test/results/clientpositive/index_bitmap3.q.out 116c973 
  ql/src/test/results/clientpositive/index_bitmap_auto.q.out cc9d91e 
  ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out 9003eb4 
  ql/src/test/results/clientpositive/index_bitmap_rc.q.out 9bd3c98 
  ql/src/test/results/clientpositive/index_compact.q.out c339ec9 
  ql/src/test/results/clientpositive/index_compact_1.q.out 34ba3ca 
  ql/src/test/results/clientpositive/index_compact_2.q.out e8ce238 
  ql/src/test/results/clientpositive/index_compact_3.q.out d39556d 
  ql/src/test/results/clientpositive/index_creation.q.out 532f07e 
  ql/src/test/results/clientpositive/show_indexes_edge_cases.q.out 709bdc0 
  ql/src/test/results/clientpositive/show_indexes_syntax.q.out 2c2a4af 

Diff: https://reviews.apache.org/r/1137/diff


Testing
-------

Added new testcase to TestCliDriver: index_auth.q


Thanks,

Syed


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message