hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amareshwari Sriramadasu" <amareshw...@apache.org>
Subject Re: Review Request: HIVE-1734. Implement map_keys() and map_values() UDFs
Date Mon, 01 Aug 2011 10:03:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1082/#review1247
-----------------------------------------------------------



ql/src/test/results/clientpositive/udf_map_keys.q.out
<https://reviews.apache.org/r/1082/#comment2850>

    Shouldn't the output be ["a", "b", "c"] here?



ql/src/test/results/clientpositive/udf_map_values.q.out
<https://reviews.apache.org/r/1082/#comment2851>

    Shouldn't the output be [1,2,3] instead of [2,1,3]? 


- Amareshwari


On 2011-07-12 00:40:11, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1082/
> -----------------------------------------------------------
> 
> (Updated 2011-07-12 00:40:11)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> This patch adds map_keys(map) and map_values(map) UDFs.
> 
> 
> This addresses bug HIVE-1734.
>     https://issues.apache.org/jira/browse/HIVE-1734
> 
> 
> Diffs
> -----
> 
>   ql/src/test/results/clientpositive/udf_map_values.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/udf_map_keys.q.out PRE-CREATION 
>   ql/src/test/queries/clientpositive/udf_map_values.q PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_map_keys_arg_num.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_map_keys_arg_type.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_map_values_arg_num.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/udf_map_values_arg_type.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out d4f6c98 
>   ql/src/test/queries/clientnegative/udf_map_values_arg_num.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_map_values_arg_type.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/udf_map_keys.q PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 16a207e 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java PRE-CREATION

>   ql/src/test/queries/clientnegative/udf_map_keys_arg_num.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/udf_map_keys_arg_type.q PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1082/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carl
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message