hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2171) Allow custom serdes to set field comments
Date Thu, 04 Aug 2011 00:19:27 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079138#comment-13079138
] 

Jakob Homan commented on HIVE-2171:
-----------------------------------

I did do the intersection and didn't see anything. I've got tests going, but don't expect
anything new as the review comments were about style rather than logic.  The was relatively
simple, so I'm not overly concerned about new problems introduced in the interim.  Updated
RB; some of the changes it shows for patch v1 to v2 are spurious and introduced by the trunk
drift.  Thanks.

> Allow custom serdes to set field comments
> -----------------------------------------
>
>                 Key: HIVE-2171
>                 URL: https://issues.apache.org/jira/browse/HIVE-2171
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HIVE-2171-2.patch, HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set its comment.
 These are set in the metastore utils to {{(from deserializer)}}.  For those serdes that can
provide meaningful comments for a field, they should be propagated to the table description.
 These serde-provided comments could be prepended to "(from deserializer)" if others feel
that's a meaningful distinction.  This change involves updating {{StructField}} to support
a (possibly null) comment field and then propagating this change out to the myriad places
{{StructField}} is thrown around.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message