hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2334) DESCRIBE TABLE causes NPE when hive.cli.print.header=true
Date Fri, 05 Aug 2011 20:38:31 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080205#comment-13080205
] 

jiraposter@reviews.apache.org commented on HIVE-2334:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1300/#review1308
-----------------------------------------------------------



cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
<https://reviews.apache.org/r/1300/#comment2967>

    Might want to consider using StringTokenizer or StreamTokenizer here.



cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java
<https://reviews.apache.org/r/1300/#comment2963>

    cli/build.xml overrides the ant test target with a no-op, so this test is actually not
getting run.



cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java
<https://reviews.apache.org/r/1300/#comment2964>

    Wildcard imports violate the checkstyle guidelines.



cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java
<https://reviews.apache.org/r/1300/#comment2965>

    There's already some very limited test coverage for the hive.cli.print.header feature
in print_header.q. Why not extend this testcase instead of adding a new unit test?



ivy/libraries.properties
<https://reviews.apache.org/r/1300/#comment2966>

    We need to manage this dependency with Ivy. The Hive build currently runs against hadoop-0.20.1,
which does not include mockito-all-1.8.2.jar


- Carl


On 2011-08-05 01:22:01, Jakob Homan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1300/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-05 01:22:01)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Commands that don't return a schema cause NPE when print headers is on.
bq.  
bq.  
bq.  This addresses bug HIVE-2334.
bq.      https://issues.apache.org/jira/browse/HIVE-2334
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 9fa7bc6 
bq.    cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java PRE-CREATION 
bq.    ivy/libraries.properties af856bd 
bq.  
bq.  Diff: https://reviews.apache.org/r/1300/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  New unit tests (both positive and negative) and verification on manual cluster.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jakob
bq.  
bq.



> DESCRIBE TABLE causes NPE when hive.cli.print.header=true
> ---------------------------------------------------------
>
>                 Key: HIVE-2334
>                 URL: https://issues.apache.org/jira/browse/HIVE-2334
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 0.7.1
>            Reporter: Carl Steinbach
>            Assignee: Jakob Homan
>         Attachments: h2334.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message