hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <>
Subject [jira] [Updated] (HIVE-2171) Allow custom serdes to set field comments
Date Wed, 03 Aug 2011 22:35:27 GMT


Jakob Homan updated HIVE-2171:

    Attachment: HIVE-2171-2.patch

Updated patch.
* rebased against trunk
* added braces around all new if statements
* checked for checkstyle errors, didn't see any, although it's difficult to be sure since
there is a baseline of 4,789 violations in trunk.

Do I need to open a new RB for this updated patch?  Do the committers run the full test suite?
 I see lots of comments like "will commit if tests pass." Does this mean that in Hive it's
up to the committers to do the testing?  Thanks.

> Allow custom serdes to set field comments
> -----------------------------------------
>                 Key: HIVE-2171
>                 URL:
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: HIVE-2171-2.patch, HIVE-2171.patch
> Currently, while serde implementations can set a field's name, they can't set its comment.
 These are set in the metastore utils to {{(from deserializer)}}.  For those serdes that can
provide meaningful comments for a field, they should be propagated to the table description.
 These serde-provided comments could be prepended to "(from deserializer)" if others feel
that's a meaningful distinction.  This change involves updating {{StructField}} to support
a (possibly null) comment field and then propagating this change out to the myriad places
{{StructField}} is thrown around.

This message is automatically generated by JIRA.
For more information on JIRA, see:


View raw message