hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2335) Indexes are still automatically queried when out of sync with their source tables
Date Thu, 18 Aug 2011 10:09:29 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086927#comment-13086927
] 

jiraposter@reviews.apache.org commented on HIVE-2335:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1260/
-----------------------------------------------------------

(Updated 2011-08-18 10:08:30.148104)


Review request for hive, John Sichi, Yongqiang He, and Ning Zhang.


Changes
-------

updated testcases


Summary
-------

Check the timestamps of the tables/partitions to ensure that they were not written to since
the index was last generated


This addresses bug HIVE-2335.
    https://issues.apache.org/jira/browse/HIVE-2335


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
8295687 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 3054f76 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterIndexDesc.java cf20b89 
  ql/src/test/queries/clientpositive/index_stale.q PRE-CREATION 
  ql/src/test/queries/clientpositive/index_stale_partitioned.q PRE-CREATION 
  ql/src/test/results/clientpositive/index_stale.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/index_stale_partitioned.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1260/diff


Testing
-------

added index_stale.q and index_stale_partitioned.q to the testcase suite


Thanks,

Syed



> Indexes are still automatically queried when out of sync with their source tables
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-2335
>                 URL: https://issues.apache.org/jira/browse/HIVE-2335
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Syed S. Albiz
>            Assignee: Syed S. Albiz
>         Attachments: HIVE-2335.1.patch, HIVE-2335.2.patch, HIVE-2335.3.patch
>
>
> The automatic index usage does not check whether or not the indexes are still up-to-date
when generating the index queries. This can be addressed in two stages, the first is to add
a check before generating the index query to ensure that the index is still valid. The next
stage may be to add some sort of mode where indexes are automatically updated on table writes.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message