hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-1916) Change Default Alias For Aggregated Columns (_c1)
Date Tue, 09 Aug 2011 22:57:28 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081985#comment-13081985
] 

jiraposter@reviews.apache.org commented on HIVE-1916:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1441/#review1368
-----------------------------------------------------------



trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/1441/#comment3136>

    Please add these definitions to hive-default.xml along with a description for each property.



trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/1441/#comment3140>

    These are initialized in the constructor. Please don't also initialize them here.



trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/1441/#comment3137>

    Please run checkstyle and correct any violations introduced by your changes.



trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
<https://reviews.apache.org/r/1441/#comment3142>

    Create a static final variable for the 20 char length limit.


- Carl


On 2011-08-09 22:40:56, sameerm wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1441/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-08-09 22:40:56)
bq.  
bq.  
bq.  Review request for hive and Ning Zhang.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Default behavior will be as before.
bq.  Adding new Hive conf vars to make the column names include the aggregation function and
params.
bq.  
bq.  
bq.  This addresses bug HIVE-1916.
bq.      https://issues.apache.org/jira/browse/HIVE-1916
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155181 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1155181 
bq.    trunk/ql/src/test/queries/clientpositive/autogen_colname.q PRE-CREATION 
bq.    trunk/ql/src/test/results/clientpositive/autogen_colname.q.out PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1441/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added new query file with expected results. All unit tests pass
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  sameerm
bq.  
bq.



> Change Default Alias For Aggregated Columns (_c1)
> -------------------------------------------------
>
>                 Key: HIVE-1916
>                 URL: https://issues.apache.org/jira/browse/HIVE-1916
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>         Environment: All
>            Reporter: James Mayfield
>            Priority: Minor
>
> Problem:
> When running a Hive query that aggregates (does a group by operation), Hive will automatically
name this column _c0, _c1, _c2, etc.. This is a problem because Hive will not then execute
a query against a column that begins with "_" and then the user has to manually input back-ticks
in order to get the query to run.
> Potential Solution:
> Hive should by default call these columns by their query assignment like "sum_active30day_users"
or if that is not possible, call it something simple like "column_1" so that users can then
query the new column without adding special back-ticks.
> Example Query:
> SELECT a.ds, COUNT(a.num_accounts)
> Example Result:
> ds, count_num_accounts OR ds, column_1

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message