hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2020) Create a separate namespace for Hive variables
Date Tue, 02 Aug 2011 22:28:28 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078474#comment-13078474
] 

jiraposter@reviews.apache.org commented on HIVE-2020:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1204/#review1273
-----------------------------------------------------------


This patch doesn't appear to address most of the issues described in HIVE-2020, which covers
adding a separate namespace for variables that is distinct from hiveconf and environment/system
properties. This patch also needs a testcase.


cli/src/java/org/apache/hadoop/hive/cli/DefaultPreprocessor.java
<https://reviews.apache.org/r/1204/#comment2906>

    Please extend/modify/use the code in org.apache.hadoop.hive.ql.parse.VariableSubstitution
instead of adding this class.



cli/src/java/org/apache/hadoop/hive/cli/OptionsProcessor.java
<https://reviews.apache.org/r/1204/#comment2905>

    I think these two option definitions can be combined, e.g:
    
    .withArgName("key=value")
    .withLongOpt("define")
    .create("d");


- Carl


On 2011-07-27 21:07:40, Vaibhav Aggarwal wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1204/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-27 21:07:40)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Create a separate option for Hive variable
bq.  
bq.  
bq.  This addresses bug HIVE-2020.
bq.      https://issues.apache.org/jira/browse/HIVE-2020
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 9fa7bc6 
bq.    cli/src/java/org/apache/hadoop/hive/cli/DefaultPreprocessor.java PRE-CREATION 
bq.    cli/src/java/org/apache/hadoop/hive/cli/KeyValue.java PRE-CREATION 
bq.    cli/src/java/org/apache/hadoop/hive/cli/OptionsProcessor.java 90084ed 
bq.    cli/src/java/org/apache/hadoop/hive/cli/Preprocessor.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1204/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Vaibhav
bq.  
bq.



> Create a separate namespace for Hive variables
> ----------------------------------------------
>
>                 Key: HIVE-2020
>                 URL: https://issues.apache.org/jira/browse/HIVE-2020
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Carl Steinbach
>            Assignee: Vaibhav Aggarwal
>         Attachments: HIVE-2020.patch
>
>
> Support for variable substitution was added in HIVE-1096. However, variable substitution
was implemented by reusing the HiveConf namespace, so there is no separation between Hive
configuration properties and Hive variables.
> This ticket encompasses the following enhancements:
> * Create a separate namespace for managing Hive variables.
> * Add support for setting variables on the command line via '-hivevar x=y'
> * Add support for setting variables through the CLI via 'var x=y'
> * Add support for referencing variables in statements using either '${hivevar:var_name}'
or '${var_name}'
> * Provide a means for differentiating between hiveconf, hivevar, system, and environment
properties in the output of 'set -v'

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message