Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Thu, 21 Jul 2011 01:21:59 +0000 (UTC)
From: "jiraposter@reviews.apache.org (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: 
 <380970539.10149.1311211319475.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1532953936.7204.1309472850116.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HIVE-2247) ALTER TABLE RENAME PARTITION
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068753#comment-13068753 ] 

jiraposter@reviews.apache.org commented on HIVE-2247:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1105/
-----------------------------------------------------------

(Updated 2011-07-21 01:20:25.242756)


Review request for Siying Dong.


Changes
-------

Refactor the code, rename_partition shares the same thrift API as alter_partition, we do alter_partition when part_vals is empty, we do rename_partition when part_vals is given 


Summary
-------

Implement ALTER TABLE PARTITION RENAME function to rename a partition. 
Add HiveQL syntax "ALTER TABLE bar PARTITION (k1='v1', k2='v2') RENAME TO PARTITION (k1='v3', k2='v4');"
This is my first Hive diff, I just learn everything from existing codebase and may not have a good understanding on it. 
Feel free to inform me if I make something wrong. Thanks


This addresses bug HIVE-2247.
    https://issues.apache.org/jira/browse/HIVE-2247


Diffs (updated)
-----

  trunk/metastore/if/hive_metastore.thrift 1145366 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1145366 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1145366 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1145366 
  trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1145366 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1145366 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1145366 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1145366 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1145366 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1145366 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1145366 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1145366 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1145366 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1145366 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1145366 
  trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1145366 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1145366 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1145366 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1145366 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1145366 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1145366 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 1145366 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1145366 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1145366 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/RenamePartitionDesc.java PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/alter_rename_partition_failure.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/alter_rename_partition_failure2.q PRE-CREATION 
  trunk/ql/src/test/queries/clientnegative/alter_rename_partition_failure3.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/alter_rename_partition.q PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/alter_rename_partition_authorization.q PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure2.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/alter_rename_partition.q.out PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1105/diff


Testing
-------

Add a partition A in the table
Rename partition A to partition B
Show the partitions in the table, it returns partition B.
SELECT the data from partition A, it returns no results
SELECT the data from partition B, it returns the data originally stored in partition A


Thanks,

Weiyan


> ALTER TABLE RENAME PARTITION
> ----------------------------
>
>                 Key: HIVE-2247
>                 URL: https://issues.apache.org/jira/browse/HIVE-2247
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Siying Dong
>            Assignee: Weiyan Wang
>         Attachments: HIVE-2247.3.patch.txt, HIVE-2247.4.patch.txt, HIVE-2247.5.patch.txt
>
>
> We need a ALTER TABLE TABLE RENAME PARTITIONfunction that is similar t ALTER TABLE RENAME.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira