Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 42D2568FD for ; Fri, 15 Jul 2011 18:28:23 +0000 (UTC) Received: (qmail 26618 invoked by uid 500); 15 Jul 2011 18:28:22 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 26283 invoked by uid 500); 15 Jul 2011 18:28:22 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 26274 invoked by uid 500); 15 Jul 2011 18:28:21 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 26262 invoked by uid 99); 15 Jul 2011 18:28:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2011 18:28:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2011 18:28:20 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 3C5225989A for ; Fri, 15 Jul 2011 18:28:00 +0000 (UTC) Date: Fri, 15 Jul 2011 18:28:00 +0000 (UTC) From: "Ning Zhang (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <275915595.18231.1310754480243.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1036664193.2123.1309905856762.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HIVE-2260) ExecDriver::addInputPaths should pass the table properties to the record writer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066113#comment-13066113 ] Ning Zhang commented on HIVE-2260: ---------------------------------- +1. Looks good to me. Will commit if tests pass. > ExecDriver::addInputPaths should pass the table properties to the record writer > ------------------------------------------------------------------------------- > > Key: HIVE-2260 > URL: https://issues.apache.org/jira/browse/HIVE-2260 > Project: Hive > Issue Type: Bug > Affects Versions: 0.7.0 > Reporter: Jakob Homan > Assignee: Jakob Homan > Attachments: HIVE-2260.patch > > > Currently when ExecDriver encounters a non-existent partition, it creates an empty file so that the query will be valid (and return 0 results). However, when it does this and calls {{getHiveRecordWriter()}}, it creates a new instance of Properties, rather than providing the Properties associated with the table. > This causes RecordWriters that pull information from the table through the Properties to fail (such as [Haivvreo|http://bit.ly/iwEQzJ]). The RecordWriter should be provided the table's Properties, as it is in all other cases where it's called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira