Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 053DE6765 for ; Tue, 19 Jul 2011 16:50:05 +0000 (UTC) Received: (qmail 61499 invoked by uid 500); 19 Jul 2011 16:50:04 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 61401 invoked by uid 500); 19 Jul 2011 16:50:04 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 61385 invoked by uid 99); 19 Jul 2011 16:50:03 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jul 2011 16:50:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C5BA51C00A8; Tue, 19 Jul 2011 16:50:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5626854382200241795==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2086. Data loss with external table From: "Jonathan Natkins" To: "Jonathan Natkins" , "Ning Zhang" , "hive" Date: Tue, 19 Jul 2011 16:50:07 -0000 Message-ID: <20110719165007.23571.7022@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/604/ In-Reply-To: <20110427160050.911.88634@reviews.apache.org> References: <20110427160050.911.88634@reviews.apache.org> --===============5626854382200241795== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/604/ ----------------------------------------------------------- (Updated 2011-07-19 16:50:07.742470) Review request for hive. Changes ------- The bug was fixed as a part of HIVE-1218, and this diff adds some regressio= n tests for this particular issue. Summary ------- Review request for HIVE-2086. The external parameters were being set, but = then being zeroed out by a call to params.clear(), resulting in an external= table that wasn't marked as external. This addresses bug HIVE-2086. https://issues.apache.org/jira/browse/HIVE-2086 Diffs (updated) ----- build-common.xml b6807fa = data/files/ext_test/test.dat PRE-CREATION = ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 6d742e5 = ql/src/test/queries/clientpositive/create_like.q 3f8e58d = ql/src/test/results/clientpositive/create_like.q.out 118235e = Diff: https://reviews.apache.org/r/604/diff Testing ------- Automated tests added Thanks, Jonathan --===============5626854382200241795==--