Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3271C6D55 for ; Fri, 15 Jul 2011 02:13:21 +0000 (UTC) Received: (qmail 45415 invoked by uid 500); 15 Jul 2011 02:13:21 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 45353 invoked by uid 500); 15 Jul 2011 02:13:20 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 45338 invoked by uid 99); 15 Jul 2011 02:13:20 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2011 02:13:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1773B1C00B7; Fri, 15 Jul 2011 02:13:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4097897749147500017==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-1078: CREATE VIEW followup: CREATE OR REPLACE From: "John Sichi" To: "John Sichi" , "Charles Chen" , "hive" Date: Fri, 15 Jul 2011 02:13:24 -0000 Message-ID: <20110715021324.21485.42293@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1058/ In-Reply-To: <20110715000243.20147.87433@reviews.apache.org> References: <20110715000243.20147.87433@reviews.apache.org> --===============4097897749147500017== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1058/#review1074 ----------------------------------------------------------- http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hi= ve/ql/exec/DDLTask.java Isn't this already covered by the "Cannot change existing partition col= umns" check above? http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hi= ve/ql/exec/DDLTask.java Instead of saving the partitions and then adding them back, it would be= better if we never had to remove them at all. Otherwise, there could be = triggers which run in the metastore which will fire spurious events. = We need a way to update the view in place. = - John On 2011-07-15 00:02:43, Charles Chen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1058/ > ----------------------------------------------------------- > = > (Updated 2011-07-15 00:02:43) > = > = > Review request for hive. > = > = > Summary > ------- > = > https://issues.apache.org/jira/browse/HIVE-1078 > = > = > This addresses bug HIVE-1078. > https://issues.apache.org/jira/browse/HIVE-1078 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpo= sitive/create_or_replace_view.q.out PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpo= sitive/create_view.q.out 1146902 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientne= gative/create_or_replace_view1.q.out PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientne= gative/create_or_replace_view2.q.out PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientne= gative/create_or_replace_view3.q.out PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientne= gative/create_or_replace_view4.q.out PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientne= gative/create_or_replace_view1.q PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientne= gative/create_or_replace_view2.q PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientne= gative/create_or_replace_view3.q PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientne= gative/create_or_replace_view4.q PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpo= sitive/create_or_replace_view.q PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoo= p/hive/ql/parse/SemanticAnalyzer.java 1146902 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoo= p/hive/ql/plan/CreateViewDesc.java 1146902 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoo= p/hive/ql/exec/DDLTask.java 1146902 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoo= p/hive/ql/parse/Hive.g 1146902 = > = > Diff: https://reviews.apache.org/r/1058/diff > = > = > Testing > ------- > = > Passes unit tests > = > = > Thanks, > = > Charles > = > --===============4097897749147500017==--