Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 245CF7A00 for ; Thu, 14 Jul 2011 20:00:21 +0000 (UTC) Received: (qmail 22399 invoked by uid 500); 14 Jul 2011 20:00:20 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 22308 invoked by uid 500); 14 Jul 2011 20:00:20 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 22294 invoked by uid 99); 14 Jul 2011 20:00:20 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jul 2011 20:00:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D09921C00B7; Thu, 14 Jul 2011 20:00:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1242602226466704957==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-1218: CREATE TABLE LIKE view From: "John Sichi" To: "John Sichi" , "Charles Chen" , "hive" Date: Thu, 14 Jul 2011 20:00:23 -0000 Message-ID: <20110714200023.21485.48078@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1057/ In-Reply-To: <20110714185432.21485.51473@reviews.apache.org> References: <20110714185432.21485.51473@reviews.apache.org> --===============1242602226466704957== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1057/#review1062 ----------------------------------------------------------- http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositi= ve/create_like.q Why are you doing DESCRIBE FORMATTED twice for these tables? http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositi= ve/create_like.q.out Shouldn't this be EXTERNAL_TABLE? - John On 2011-07-14 18:54:32, Charles Chen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1057/ > ----------------------------------------------------------- > = > (Updated 2011-07-14 18:54:32) > = > = > Review request for hive. > = > = > Summary > ------- > = > https://issues.apache.org/jira/browse/HIVE-1218 > = > = > This addresses bug HIVE-1218. > https://issues.apache.org/jira/browse/HIVE-1218 > = > = > Diffs > ----- > = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoo= p/hive/ql/exec/DDLTask.java 1146841 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoo= p/hive/ql/parse/SemanticAnalyzer.java 1146841 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoo= p/hive/ql/plan/CreateTableLikeDesc.java 1146841 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpo= sitive/create_like.q 1146841 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpo= sitive/create_like_view.q PRE-CREATION = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpo= sitive/create_like.q.out 1146841 = > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpo= sitive/create_like_view.q.out PRE-CREATION = > = > Diff: https://reviews.apache.org/r/1057/diff > = > = > Testing > ------- > = > Unit tests passed > = > = > Thanks, > = > Charles > = > --===============1242602226466704957==--