Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95F976E9B for ; Tue, 12 Jul 2011 19:39:29 +0000 (UTC) Received: (qmail 71875 invoked by uid 500); 12 Jul 2011 19:39:29 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 71843 invoked by uid 500); 12 Jul 2011 19:39:29 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 71829 invoked by uid 99); 12 Jul 2011 19:39:29 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jul 2011 19:39:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 985C51C0055; Tue, 12 Jul 2011 19:39:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3855820660696216986==" MIME-Version: 1.0 Subject: Review Request: HIVE-2281: Regression introduced from HIVE-2155 From: "Syed Albiz" To: "Ning Zhang" Date: Tue, 12 Jul 2011 19:39:32 -0000 Message-ID: <20110712193932.21485.64175@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/1094/ Cc: "Syed Albiz" ,"hive" --===============3855820660696216986== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1094/ ----------------------------------------------------------- Review request for hive and Ning Zhang. Summary ------- Add defensive checks on operator stack when constructing the error message for invalid aggregate expressions (Expression not in GROUP BY...) This addresses bug HIVE-2281. https://issues.apache.org/jira/browse/HIVE-2281 Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java dfa= db9f = ql/src/test/queries/clientnegative/nonkey_groupby.q PRE-CREATION = ql/src/test/results/clientnegative/nonkey_groupby.q.out PRE-CREATION = Diff: https://reviews.apache.org/r/1094/diff Testing ------- Added new unit test (nonkey_groupby.q) to NegativeCliDriver suite, made sure no breakage to existing tests covering this message: groupby_key.q,notable_alias3.q (TestNegativeCliDriver) nonkey_groupby.q,unknown_column6.q (TestNegativeParseDriver) Thanks, Syed --===============3855820660696216986==--