Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6A815442F for ; Sun, 3 Jul 2011 23:37:18 +0000 (UTC) Received: (qmail 34311 invoked by uid 500); 3 Jul 2011 23:37:18 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 34189 invoked by uid 500); 3 Jul 2011 23:37:17 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 34175 invoked by uid 99); 3 Jul 2011 23:37:17 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Jul 2011 23:37:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9D19B1C00F8; Sun, 3 Jul 2011 23:37:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5279298807199376060==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2224 : Exposing add_partitions() from hive metastore, making it atomic From: "Sushanth Sowmyan" To: "Sushanth Sowmyan" , "hive" Date: Sun, 03 Jul 2011 23:37:20 -0000 Message-ID: <20110703233720.29742.91735@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/999/ In-Reply-To: <20110703232952.609.76239@reviews.apache.org> References: <20110703232952.609.76239@reviews.apache.org> --===============5279298807199376060== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/999/ ----------------------------------------------------------- (Updated 2011-07-03 23:37:20.552434) Review request for hive. Summary ------- As per HIVE-2224 ( https://issues.apache.org/jira/browse/HIVE-2224 ), this = patch does the following: + Exposing add_partitions() from the thrift metastore api + Making add_partitions() atomic Diffs ----- http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.th= rift 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-c= pp/ThriftHiveMetastore.h 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-c= pp/ThriftHiveMetastore.cpp 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-c= pp/ThriftHiveMetastore_server.skeleton.cpp 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-j= avabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 11421= 16 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-p= hp/hive_metastore/ThriftHiveMetastore.php 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-p= y/hive_metastore/ThriftHiveMetastore-remote 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-p= y/hive_metastore/ThriftHiveMetastore.py 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-r= b/thrift_hive_metastore.rb 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/= hadoop/hive/metastore/HiveMetaStore.java 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/= hadoop/hive/metastore/HiveMetaStoreClient.java 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/= hadoop/hive/metastore/IMetaStoreClient.java 1142116 = http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/= hadoop/hive/metastore/TestHiveMetaStore.java 1142116 = Diff: https://reviews.apache.org/r/999/diff Testing (updated) ------- Modified TestHiveMetaStore.partitionTester() to add tests for the following= scenarios: + add_partition(empty list) : no exceptions thrown : works + add_partitions(list containing 3 partitions) : works, verified that parti= tions exist + add_partitions(list containing 2 partitions, where one of them has keyval= ues identical to original partition, and another partition has a directory = already created, verified that the call causes an exception, and directorie= s are unchanged(the one with the dir pre-existing continues to exist), and = no additional partition was published. + add_partitions(list with a single partition) : works, does not fault on d= uplicate as a result of a partial publish above. + verified that all above created partitions exist : works All of the above is called from both TestEmbeddedHiveMetaStore and TestRemo= teHiveMetaStore Thanks, Sushanth --===============5279298807199376060==--