Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F6E37C5A for ; Mon, 18 Jul 2011 20:48:20 +0000 (UTC) Received: (qmail 72323 invoked by uid 500); 18 Jul 2011 20:48:20 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 72239 invoked by uid 500); 18 Jul 2011 20:48:19 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 72229 invoked by uid 500); 18 Jul 2011 20:48:19 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 72225 invoked by uid 99); 18 Jul 2011 20:48:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jul 2011 20:48:19 +0000 X-ASF-Spam-Status: No, hits=-2001.1 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jul 2011 20:48:17 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 739A742A64 for ; Mon, 18 Jul 2011 20:47:57 +0000 (UTC) Date: Mon, 18 Jul 2011 20:47:57 +0000 (UTC) From: "jiraposter@reviews.apache.org (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: <1043784190.1561.1311022077470.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1957527369.41575.1306306487433.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HIVE-2184) Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067285#comment-13067285 ] jiraposter@reviews.apache.org commented on HIVE-2184: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1088/#review1099 ----------------------------------------------------------- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java We should get rid of the member variable standAloneClient too since it is part of the dead code. Now that we'll start calling shutdown (which we were skipping before), what will be the effect? - John On 2011-07-12 14:06:28, chinna wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1088/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-07-12 14:06:28) bq. bq. bq. Review request for hive and John Sichi. bq. bq. bq. Summary bq. ------- bq. bq. Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close() bq. bq. bq. This addresses bug HIVE-2184. bq. https://issues.apache.org/jira/browse/HIVE-2184 bq. bq. bq. Diffs bq. ----- bq. bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1144190 bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1144190 bq. bq. Diff: https://reviews.apache.org/r/1088/diff bq. bq. bq. Testing bq. ------- bq. bq. Ran all the testcases bq. bq. bq. Thanks, bq. bq. chinna bq. bq. > Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close() > ------------------------------------------------------------------- > > Key: HIVE-2184 > URL: https://issues.apache.org/jira/browse/HIVE-2184 > Project: Hive > Issue Type: Bug > Components: Metastore > Affects Versions: 0.5.0, 0.8.0 > Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5) > Reporter: Chinna Rao Lalam > Assignee: Chinna Rao Lalam > Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.patch > > > 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient" is never become true then client.shutdown() never call. > 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira