hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2319) Calling alter_table after changing partition comment throws an exception
Date Thu, 28 Jul 2011 21:52:11 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072552#comment-13072552
] 

jiraposter@reviews.apache.org commented on HIVE-2319:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1213/#review1215
-----------------------------------------------------------



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
<https://reviews.apache.org/r/1213/#comment2712>

    Actually, we can't allow for a different ordering because that would imply a different
directory structure. We should just make sure that everything but the comments are equal.



trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
<https://reviews.apache.org/r/1213/#comment2713>

    Message should say - it was able to change when it shouldn't have?


- Paul


On 2011-07-28 07:06:24, Sohan Jain wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1213/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-28 07:06:24)
bq.  
bq.  
bq.  Review request for hive and Paul Yang.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Altering a table's partition key comments raises an InvalidOperationException. The partition
key name and type should not be mutable, but the comment should be able to get changed.
bq.  
bq.  
bq.  This addresses bug HIVE-2319.
bq.      https://issues.apache.org/jira/browse/HIVE-2319
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1151219

bq.    trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1151219

bq.  
bq.  Diff: https://reviews.apache.org/r/1213/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added some test cases to HiveMetaStore that pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Sohan
bq.  
bq.



> Calling alter_table after changing partition comment throws an exception
> ------------------------------------------------------------------------
>
>                 Key: HIVE-2319
>                 URL: https://issues.apache.org/jira/browse/HIVE-2319
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Sohan Jain
>            Assignee: Sohan Jain
>         Attachments: HIVE-2319.2.patch
>
>
> Altering a table's partition key comments raises an InvalidOperationException.  The partition
key name and type should not be mutable, but the comment should be able to get changed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message