hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2183) In Task class and its subclasses logger is initialized in constructor
Date Fri, 29 Jul 2011 23:28:10 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073067#comment-13073067
] 

Hudson commented on HIVE-2183:
------------------------------

Integrated in Hive-trunk-h0.21 #860 (See [https://builds.apache.org/job/Hive-trunk-h0.21/860/])
    HIVE-2183. In Task class and its subclasses logger is initialized in
constructor
(Chinna Rao Lalam via jvs)

jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1152340
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java


> In Task class and its subclasses logger is initialized in constructor
> ---------------------------------------------------------------------
>
>                 Key: HIVE-2183
>                 URL: https://issues.apache.org/jira/browse/HIVE-2183
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2
(i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: HIVE-2183.1.patch, HIVE-2183.2.patch, HIVE-2183.patch
>
>
> In Task class and its subclasses logger is initialized in constructor. Log object no
need to initialize every time in the constructor, Log object can make it as static object.
> {noformat}
> Ex:
>   public ExecDriver() {
>     super();
>     LOG = LogFactory.getLog(this.getClass().getName());
>     console = new LogHelper(LOG);
>     this.jobExecHelper = new HadoopJobExecHelper(job, console, this, this);
>   }
> {noformat}
> Need to change like this
> {noformat}
> private static final Log LOG = LogFactory.getLog(ExecDriver.class);
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message