hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-1218) CREATE TABLE t LIKE some_view should create a new empty base table, but instead creates a copy of view
Date Tue, 12 Jul 2011 21:07:01 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064137#comment-13064137
] 

jiraposter@reviews.apache.org commented on HIVE-1218:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/#review1039
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/1057/#comment2112>

    indentation?



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q
<https://reviews.apache.org/r/1057/#comment2115>

    Can you include a testcase for a partitioned view?  I don't see a codepath for that (we
agreed the new table should come out with the same partition columns as the view).
    
    Also add a testcase for create externa table like base_table since you fixed a bug in
that existing codepath.  You can put that in create_like.q since it doesn't have anything
to do with views.



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q
<https://reviews.apache.org/r/1057/#comment2116>

    Add order by on these queries for determinism.


- John


On 2011-07-11 22:06:40, Charles Chen wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1057/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-11 22:06:40)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  https://issues.apache.org/jira/browse/HIVE-1218
bq.  
bq.  
bq.  This addresses bug HIVE-1218.
bq.      https://issues.apache.org/jira/browse/HIVE-1218
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
1145292 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java
1145292 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1145292 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java
1145292 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1057/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Charles
bq.  
bq.



> CREATE TABLE t LIKE some_view should create a new empty base table, but instead creates
a copy of view
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-1218
>                 URL: https://issues.apache.org/jira/browse/HIVE-1218
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-1218v0.patch
>
>
> I think it should copy only the column definitions from the view metadata.  Currently
it is copying the entire descriptor, resulting in a new view instead of a new base table.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message