hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-1078) CREATE VIEW followup: CREATE OR REPLACE
Date Mon, 18 Jul 2011 07:03:09 GMT

    [ https://issues.apache.org/jira/browse/HIVE-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066819#comment-13066819
] 

jiraposter@reviews.apache.org commented on HIVE-1078:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1058/#review1088
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/1058/#comment2222>

    Haha ok so now I remember why we need this:
    
    (unit test clientnegative/create_or_replace_view1.q):
    -- New view must contain all old partition columns.
    
    drop view v;
    create view v partitioned on (ds, hr) as select * from srcpart;
    create or replace view v as select key, hr from srcpart;
    
    Here, we don't explicitly change the partition columns, so the new view inherits the old
columns, but those columns better still exist.


- Charles


On 2011-07-18 07:01:02, Charles Chen wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1058/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-18 07:01:02)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  https://issues.apache.org/jira/browse/HIVE-1078
bq.  
bq.  
bq.  This addresses bug HIVE-1078.
bq.      https://issues.apache.org/jira/browse/HIVE-1078
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_view.q.out
1146902 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_or_replace_view.q.out
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/create_or_replace_view4.q.out
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
1146902 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
1146902 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
1146902 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1146902 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java
1146902 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/create_or_replace_view1.q
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/create_or_replace_view2.q
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/create_or_replace_view3.q
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/create_or_replace_view4.q
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_or_replace_view.q
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/create_or_replace_view1.q.out
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/create_or_replace_view2.q.out
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/create_or_replace_view3.q.out
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1058/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Passes unit tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Charles
bq.  
bq.



> CREATE VIEW followup:  CREATE OR REPLACE
> ----------------------------------------
>
>                 Key: HIVE-1078
>                 URL: https://issues.apache.org/jira/browse/HIVE-1078
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: Charles Chen
>         Attachments: HIVE-1078v3.patch, HIVE-1078v4.patch, HIVE-1078v5.patch
>
>
> Currently, replacing a view requires
> DROP VIEW v;
> CREATE VIEW v AS <new-definition>;
> CREATE OR REPLACE would allow these to be combined into a single operation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message