hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sohan Jain" <sohanj...@fb.com>
Subject Re: Review Request: HIVE-2319: Calling alter_table after changing partition key comment throws an exception
Date Thu, 28 Jul 2011 23:24:52 GMT


> On 2011-07-28 21:51:59, Paul Yang wrote:
> > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java,
lines 232-233
> > <https://reviews.apache.org/r/1213/diff/2/?file=28094#file28094line232>
> >
> >     Actually, we can't allow for a different ordering because that would imply a
different directory structure. We should just make sure that everything but the comments are
equal.

Ok cool, that cleans up the code quite a bit.  The previous implementation only checked if
the partition key lists were of the same size, and one contained all elements of the other.
 That is, it did not ensure ordering.


> On 2011-07-28 21:51:59, Paul Yang wrote:
> > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java,
line 1036
> > <https://reviews.apache.org/r/1213/diff/2/?file=28095#file28095line1036>
> >
> >     Message should say - it was able to change when it shouldn't have?

Fixed


- Sohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1213/#review1215
-----------------------------------------------------------


On 2011-07-28 07:06:24, Sohan Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1213/
> -----------------------------------------------------------
> 
> (Updated 2011-07-28 07:06:24)
> 
> 
> Review request for hive and Paul Yang.
> 
> 
> Summary
> -------
> 
> Altering a table's partition key comments raises an InvalidOperationException. The partition
key name and type should not be mutable, but the comment should be able to get changed.
> 
> 
> This addresses bug HIVE-2319.
>     https://issues.apache.org/jira/browse/HIVE-2319
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1151219

>   trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1151219

> 
> Diff: https://reviews.apache.org/r/1213/diff
> 
> 
> Testing
> -------
> 
> Added some test cases to HiveMetaStore that pass.
> 
> 
> Thanks,
> 
> Sohan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message