hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Wilfong" <kevinwilf...@fb.com>
Subject Re: Review Request: Local mode needs to work well with block sampling
Date Fri, 22 Jul 2011 17:40:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1132/
-----------------------------------------------------------

(Updated 2011-07-22 17:40:44.736466)


Review request for hive and Siying Dong.


Changes
-------

I added the q.out file which I had forgotten for the new q file.

I also modified the test queries to select count(1) instead of selecting keys and values.


Summary
-------

A query should run in local mode when block sampling is used and the sample is small enough.
 The size of the sample is currently being estimated, as it is done to estimate the number
of reducers.


This addresses bug HIVE-2282.
    https://issues.apache.org/jira/browse/HIVE-2282


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java 53769a0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cd3de76 
  ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyIsLocalModeHook.java PRE-CREATION 
  ql/src/test/queries/clientpositive/sample_islocalmode_hook.q PRE-CREATION 
  ql/src/test/results/clientpositive/sample_islocalmode_hook.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1132/diff


Testing
-------

TestCliDriver TestNegativeCliDriver, manually tested


Thanks,

Kevin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message