hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Hunt" <ph...@apache.org>
Subject Re: Review Request: HIVE-2139: Enables HiveServer to accept -hiveconf option
Date Tue, 19 Jul 2011 20:14:47 GMT


> On 2011-07-19 00:08:19, Carl Steinbach wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, line 3382
> > <https://reviews.apache.org/r/958/diff/2/?file=26007#file26007line3382>
> >
> >     This should be $METASTORE_PORT instead of HIVE_PORT (see metastore.sh).

I missed that, thanks.


> On 2011-07-19 00:08:19, Carl Steinbach wrote:
> > common/build.xml, line 30
> > <https://reviews.apache.org/r/958/diff/2/?file=26001#file26001line30>
> >
> >     This target overrides the definition of 'compile' in build-common.xml, but neglects
to include this action which copies over hive-log4j.properties:
> >     
> >         <copy todir="${build.classes}" failonerror="false">
> >           <fileset dir="${src.dir}/conf"/>
> >         </copy>
> >     
> >     If this is added in I think the missing hive-log4j.properties issue will be
resolved.

Ok -- FYI I originally copied this section from cli/build.xml, not build-common.xml. (it's
the same except for this missing copy)


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/958/#review1106
-----------------------------------------------------------


On 2011-07-15 23:51:55, Patrick Hunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/958/
> -----------------------------------------------------------
> 
> (Updated 2011-07-15 23:51:55)
> 
> 
> Review request for hive and Carl Steinbach.
> 
> 
> Summary
> -------
> 
> This patch updates HiveServer and HiveMetastore to add proper cli handling - similar
to that used in CliDriver (ie GnuParser).
> 
> There's a common HiveCli class that's used by both main classes.
> 
> I've attempted to make the cli's backward compatible with the prior command line processing.
Notice I've "deprecated" (via warnings, but the code still runs) if the old style CLI usage
is used.
> 
> commands such as the following now work as expected:
> 
> bin/hive --service hiveserver -t 200 -p 12000 --hiveconf hive.root.logger=DEBUG,console
> 
> as does the following which generates usage information:
> 
> bin/hive --service hiveserver -h
> 
> Note: HiveMetastore as not initializing log4j, I updated the code to do similar to HiveServer
(otw the hiveconf hive.root.logger option above didn't work).
> 
> 
> This addresses bug HIVE-2139.
>     https://issues.apache.org/jira/browse/HIVE-2139
> 
> 
> Diffs
> -----
> 
>   ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 728958d 
>   service/src/java/org/apache/hadoop/hive/service/HiveServer.java ea04be9 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 090ecfc 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 61393c8 
>   bin/ext/hiveserver.sh b5edce4 
>   bin/ext/metastore.sh db15f6e 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java bd9f6b1 
>   common/build.xml 0969e16 
>   common/ivy.xml bee3bf0 
>   common/src/java/org/apache/hadoop/hive/common/LogUtils.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/cli/CommonCliOptions.java PRE-CREATION

>   hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java 1bf8c97 
>   metastore/ivy.xml 83218fc 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java e540c63 
> 
> Diff: https://reviews.apache.org/r/958/diff
> 
> 
> Testing
> -------
> 
> I couldn't find any tests for these changes, so I verfied the changes manually.
> 
> 
> Thanks,
> 
> Patrick
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message