hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Natkins" <na...@cloudera.com>
Subject Re: Review Request: HIVE-2086. Data loss with external table
Date Tue, 19 Jul 2011 16:50:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/604/
-----------------------------------------------------------

(Updated 2011-07-19 16:50:07.742470)


Review request for hive.


Changes
-------

The bug was fixed as a part of HIVE-1218, and this diff adds some regression tests for this
particular issue.


Summary
-------

Review request for HIVE-2086.  The external parameters were being set, but then being zeroed
out by a call to params.clear(), resulting in an external table that wasn't marked as external.


This addresses bug HIVE-2086.
    https://issues.apache.org/jira/browse/HIVE-2086


Diffs (updated)
-----

  build-common.xml b6807fa 
  data/files/ext_test/test.dat PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 6d742e5 
  ql/src/test/queries/clientpositive/create_like.q 3f8e58d 
  ql/src/test/results/clientpositive/create_like.q.out 118235e 

Diff: https://reviews.apache.org/r/604/diff


Testing
-------

Automated tests added


Thanks,

Jonathan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message