hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Chen" <charlesc...@fb.com>
Subject Re: Review Request: HIVE-1078: CREATE VIEW followup: CREATE OR REPLACE
Date Mon, 18 Jul 2011 07:01:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1058/#review1088
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/1058/#comment2222>

    Haha ok so now I remember why we need this:
    
    (unit test clientnegative/create_or_replace_view1.q):
    -- New view must contain all old partition columns.
    
    drop view v;
    create view v partitioned on (ds, hr) as select * from srcpart;
    create or replace view v as select key, hr from srcpart;
    
    Here, we don't explicitly change the partition columns, so the new view inherits the old
columns, but those columns better still exist.


- Charles


On 2011-07-18 07:01:02, Charles Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1058/
> -----------------------------------------------------------
> 
> (Updated 2011-07-18 07:01:02)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-1078
> 
> 
> This addresses bug HIVE-1078.
>     https://issues.apache.org/jira/browse/HIVE-1078
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_view.q.out
1146902 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_or_replace_view.q.out
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/create_or_replace_view4.q.out
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
1146902 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
1146902 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
1146902 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1146902 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java
1146902 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/create_or_replace_view1.q
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/create_or_replace_view2.q
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/create_or_replace_view3.q
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/create_or_replace_view4.q
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_or_replace_view.q
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/create_or_replace_view1.q.out
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/create_or_replace_view2.q.out
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/create_or_replace_view3.q.out
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1058/diff
> 
> 
> Testing
> -------
> 
> Passes unit tests
> 
> 
> Thanks,
> 
> Charles
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message