hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siying Dong" <siyin...@fb.com>
Subject Re: Review Request: Local mode needs to work well with block sampling
Date Fri, 15 Jul 2011 17:16:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1132/#review1081
-----------------------------------------------------------



ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyIsLocalModeHook.java
<https://reviews.apache.org/r/1132/#comment2210>

    We need a header for licensing.


- Siying


On 2011-07-15 02:16:34, Kevin Wilfong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1132/
> -----------------------------------------------------------
> 
> (Updated 2011-07-15 02:16:34)
> 
> 
> Review request for hive and Siying Dong.
> 
> 
> Summary
> -------
> 
> A query should run in local mode when block sampling is used and the sample is small
enough.  The size of the sample is currently being estimated, as it is done to estimate the
number of reducers.
> 
> 
> This addresses bug HIVE-2282.
>     https://issues.apache.org/jira/browse/HIVE-2282
> 
> 
> Diffs
> -----
> 
>   ql/src/test/queries/clientpositive/sample_islocalmode_hook.q PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java 53769a0 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cd3de76 
>   ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyIsLocalModeHook.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/1132/diff
> 
> 
> Testing
> -------
> 
> TestCliDriver TestNegativeCliDriver, manually tested
> 
> 
> Thanks,
> 
> Kevin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message