hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sichi" <jsi...@fb.com>
Subject Re: Review Request: HIVE-1218: CREATE TABLE LIKE view
Date Thu, 14 Jul 2011 20:00:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1057/#review1062
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q
<https://reviews.apache.org/r/1057/#comment2134>

    Why are you doing DESCRIBE FORMATTED twice for these tables?



http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out
<https://reviews.apache.org/r/1057/#comment2135>

    Shouldn't this be EXTERNAL_TABLE?


- John


On 2011-07-14 18:54:32, Charles Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1057/
> -----------------------------------------------------------
> 
> (Updated 2011-07-14 18:54:32)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-1218
> 
> 
> This addresses bug HIVE-1218.
>     https://issues.apache.org/jira/browse/HIVE-1218
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableLikeDesc.java
1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like.q
1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/create_like_view.q
PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like.q.out
1146841 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/create_like_view.q.out
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/1057/diff
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Charles
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message