hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Syed Albiz" <s.s.al...@gmail.com>
Subject Re: Review Request: HIVE-2128: Automatic Indexing with multiple tables
Date Wed, 13 Jul 2011 00:29:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1010/
-----------------------------------------------------------

(Updated 2011-07-13 00:29:56.738368)


Review request for hive and John Sichi.


Changes
-------

Revamped approach. We already uniquely assign filenames to each index query result, so instead
of throwing those away, keep them in the indexIntermediateFile variable, and take the union
of those input paths to generate the next set of input splits.


Summary
-------

Grab the indexed tables during optimized query generation, grab the associated path URIs,
and keep those around in the Configuration object. When the job is passed to ExecDriver, this
data is extracted and used in HiveIndexedInputFormat to decide whether to use the index file
or delegate to the parent (HiveInputFormat) class. Not sure if this is robust. 


This addresses bug HIVE-2128.
    https://issues.apache.org/jira/browse/HIVE-2128


Diffs (updated)
-----

  ql/src/test/results/clientpositive/index_auto_self_join.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/index_auto_mult_tables_compact.q.out PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java b278ffe 
  ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java 617723e 
  ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexResult.java b9b586e 
  ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java f1ee95d 
  ql/src/java/org/apache/hadoop/hive/ql/index/TableBasedIndexHandler.java 02ab78c 
  ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 61bbbf5 
  ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 7c91946 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
dbc489f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java a03a9a6 
  ql/src/test/queries/clientpositive/index_auto_mult_tables.q PRE-CREATION 
  ql/src/test/queries/clientpositive/index_auto_mult_tables_compact.q PRE-CREATION 
  ql/src/test/queries/clientpositive/index_auto_self_join.q PRE-CREATION 
  ql/src/test/results/clientpositive/index_auto_mult_tables.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1010/diff


Testing
-------

added new testcase index_auto_mult_tables.q


Thanks,

Syed


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message