hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sushanth Sowmyan" <khorg...@gmail.com>
Subject Re: Review Request: HIVE-2224 : Exposing add_partitions() from hive metastore, making it atomic
Date Sun, 03 Jul 2011 23:37:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/999/
-----------------------------------------------------------

(Updated 2011-07-03 23:37:20.552434)


Review request for hive.


Summary
-------

As per HIVE-2224 ( https://issues.apache.org/jira/browse/HIVE-2224 ), this patch does the
following:

+ Exposing add_partitions() from the thrift metastore api
+ Making add_partitions() atomic


Diffs
-----

  http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
1142116 

Diff: https://reviews.apache.org/r/999/diff


Testing (updated)
-------

Modified TestHiveMetaStore.partitionTester() to add tests for the following scenarios:

+ add_partition(empty list) : no exceptions thrown : works
+ add_partitions(list containing 3 partitions) : works, verified that partitions exist
+ add_partitions(list containing 2 partitions, where one of them has keyvalues identical to
original partition, and another partition has a directory already created, verified that the
call causes an exception, and directories are unchanged(the one with the dir pre-existing
continues to exist), and no additional partition was published.
+ add_partitions(list with a single partition) : works, does not fault on duplicate as a result
of a partial publish above.
+ verified that all above created partitions exist : works

All of the above is called from both TestEmbeddedHiveMetaStore and TestRemoteHiveMetaStore


Thanks,

Sushanth


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message