hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2224) Ability to add_partitions, and atomically
Date Thu, 07 Jul 2011 23:22:18 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061661#comment-13061661
] 

jiraposter@reviews.apache.org commented on HIVE-2224:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/999/
-----------------------------------------------------------

(Updated 2011-07-07 23:20:22.001216)


Review request for hive.


Summary
-------

As per HIVE-2224 ( https://issues.apache.org/jira/browse/HIVE-2224 ), this patch does the
following:

+ Exposing add_partitions() from the thrift metastore api
+ Making add_partitions() atomic


This addresses bug HIVE-2224.
    https://issues.apache.org/jira/browse/HIVE-2224


Diffs
-----

  http://svn.apache.org/repos/asf/hive/trunk/metastore/if/hive_metastore.thrift 1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
1142116 
  http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
1142116 

Diff: https://reviews.apache.org/r/999/diff


Testing
-------

Modified TestHiveMetaStore.partitionTester() to add tests for the following scenarios:

+ add_partition(empty list) : no exceptions thrown : works
+ add_partitions(list containing 3 partitions) : works, verified that partitions exist
+ add_partitions(list containing 2 partitions, where one of them has keyvalues identical to
original partition, and another partition has a directory already created, verified that the
call causes an exception, and directories are unchanged(the one with the dir pre-existing
continues to exist), and no additional partition was published.
+ add_partitions(list with a single partition) : works, does not fault on duplicate as a result
of a partial publish above.
+ verified that all above created partitions exist : works

All of the above is called from both TestEmbeddedHiveMetaStore and TestRemoteHiveMetaStore


Thanks,

Sushanth



> Ability to add_partitions, and atomically
> -----------------------------------------
>
>                 Key: HIVE-2224
>                 URL: https://issues.apache.org/jira/browse/HIVE-2224
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-2224.patch
>
>
> I'd like to see an atomic version of the add_partitions() call.
> Whether this is to be done by config to affect add_partitions() behaviour (not my preference)
or just changing add_partitions() default behaviour (my preference, but likely to affect current
behaviour, so will need others' input) or by making a new add_partitions_atomic() call depends
on discussion.
> This looks relatively doable to implement (will need a dependent add_partition_core to
not do a ms.commit_partition() early, and to cache list of directories created to remove on
rollback, and a list of AddPartitionEvent to trigger in one shot later)
> Thoughts? This also seems like something to implement for allowing HIVE-1805.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message