hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2256) Better error message in CLI on invalid column name
Date Thu, 07 Jul 2011 21:01:19 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061586#comment-13061586
] 

jiraposter@reviews.apache.org commented on HIVE-2256:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1031/
-----------------------------------------------------------

Review request for hive.


Summary
-------

In the CLI, if a user inputs an incorrect column name, we currently just print the bad column
name in the query. Typically, the user needs to "describe" the table to figure out the correct
column.

This patch prints out a list of valid column and partition names in the table when a user
inputs an incorrect column name.

e.g., 
Error in semantic analysis: Invalid table alias or column reference 'col_does_not_exist' (possible
column names are: col1, col2)


This addresses bug HIVE-2256.
    https://issues.apache.org/jira/browse/HIVE-2256


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 1140399 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1140399 
  trunk/ql/src/test/results/clientnegative/clustern4.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/input2.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/regex_col_groupby.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin1.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin2.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin3.q.out 1140399 
  trunk/ql/src/test/results/clientnegative/semijoin4.q.out 1140399 
  trunk/ql/src/test/results/compiler/errors/unknown_column4.q.out 1140399 
  trunk/ql/src/test/results/compiler/errors/unknown_column5.q.out 1140399 

Diff: https://reviews.apache.org/r/1031/diff


Testing
-------

Checked the outputs of relevant unit tests, and they looks good.


Thanks,

Sohan



> Better error message in CLI on invalid column name
> --------------------------------------------------
>
>                 Key: HIVE-2256
>                 URL: https://issues.apache.org/jira/browse/HIVE-2256
>             Project: Hive
>          Issue Type: Improvement
>          Components: CLI, Query Processor
>            Reporter: Sohan Jain
>            Assignee: Sohan Jain
>         Attachments: HIVE-2256.1.patch, HIVE-2256.2.patch
>
>
> In the CLI, if a user inputs an incorrect column name, we currently just print the bad
column name in the query.  Typically, the user needs to "describe" the table to figure out
the correct column.
> This patch prints out a list of valid column and partition names in the table when a
user inputs an incorrect column name.
> e.g., 
> {{Error in semantic analysis: Invalid table alias or column reference 'col_does_not_exist'
(possible column names are: col1, col2)}}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message