hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-2184) Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
Date Mon, 18 Jul 2011 20:47:57 GMT

    [ https://issues.apache.org/jira/browse/HIVE-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067285#comment-13067285
] 

jiraposter@reviews.apache.org commented on HIVE-2184:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1088/#review1099
-----------------------------------------------------------



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
<https://reviews.apache.org/r/1088/#comment2230>

    We should get rid of the member variable standAloneClient too since it is part of the
dead code.
    
    Now that we'll start calling shutdown (which we were skipping before), what will be the
effect?
    


- John


On 2011-07-12 14:06:28, chinna wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1088/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-12 14:06:28)
bq.  
bq.  
bq.  Review request for hive and John Sichi.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
bq.  
bq.  
bq.  This addresses bug HIVE-2184.
bq.      https://issues.apache.org/jira/browse/HIVE-2184
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
1144190 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1144190 
bq.  
bq.  Diff: https://reviews.apache.org/r/1088/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran all the testcases
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  chinna
bq.  
bq.



> Few improvements in org.apache.hadoop.hive.ql.metadata.Hive.close()
> -------------------------------------------------------------------
>
>                 Key: HIVE-2184
>                 URL: https://issues.apache.org/jira/browse/HIVE-2184
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.5.0, 0.8.0
>         Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise Server 10 SP2
(i586) - Kernel 2.6.16.60-0.21-smp (5)
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>         Attachments: HIVE-2184.1.patch, HIVE-2184.1.patch, HIVE-2184.patch
>
>
> 1)Hive.close() will call HiveMetaStoreClient.close() in this method the variable "standAloneClient"
is never become true then client.shutdown() never call.
> 2)Hive.close() After calling metaStoreClient.close() need to make metaStoreClient=null

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message