Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Fri, 17 Jun 2011 02:50:49 +0000 (UTC)
From: "jiraposter@reviews.apache.org (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: 
 <2018700737.13858.1308279049294.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2077316511.13474.1308270047513.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HIVE-2227) Remove ProgressCounter enum in
 Operator
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050876#comment-13050876 ] 

jiraposter@reviews.apache.org commented on HIVE-2227:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/931/
-----------------------------------------------------------

(Updated 2011-06-17 02:49:48.793536)


Review request for hive and Yongqiang He.


Changes
-------

update bugs number


Summary
-------

After HIVE-1701, it is of no use to keep a heavy counterNameToEnum hashmap. We can use string directly, for the enum is only a hack for hadoop 0.17. The string will be human readable in the jobdetails.jsp instead of C1, C2, ... C1000.


This addresses bug HIVE-2227.
    https://issues.apache.org/jira/browse/HIVE-2227


Diffs
-----

  http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1136381 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 1136381 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1136381 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1136381 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 1136381 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 1136381 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1136381 

Diff: https://reviews.apache.org/r/931/diff


Testing
-------


Thanks,

Zhuoluo


> Remove ProgressCounter enum in Operator
> ---------------------------------------
>
>                 Key: HIVE-2227
>                 URL: https://issues.apache.org/jira/browse/HIVE-2227
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.8.0
>            Reporter: Zhuoluo (Clark) Yang
>            Priority: Minor
>             Fix For: 0.8.0
>
>         Attachments: HIVE-2227-1.patch
>
>
> After HIVE-1701, it is of no use to keep a heavy counterNameToEnum hashmap. We can use string directly, for the enum is only a hack for hadoop 0.17. The string will be human readable in the jobdetails.jsp instead of C1, C2, ... C1000.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira