Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD3156ECE for ; Tue, 28 Jun 2011 20:07:36 +0000 (UTC) Received: (qmail 82343 invoked by uid 500); 28 Jun 2011 20:07:36 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 82150 invoked by uid 500); 28 Jun 2011 20:07:35 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 82014 invoked by uid 99); 28 Jun 2011 20:07:35 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2011 20:07:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 57D5E1C0049; Tue, 28 Jun 2011 20:07:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1251886407570564740==" MIME-Version: 1.0 Subject: Review Request: HIVE-1537 - Allow users to specify LOCATION in CREATE DATABASE statement From: "Thiruvel Thirumoolan" To: "Ning Zhang" , "Amareshwari Sriramadasu" , "Ashutosh Chauhan" Date: Tue, 28 Jun 2011 20:07:38 -0000 Message-ID: <20110628200738.29522.43443@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/973/ Cc: "Thiruvel Thirumoolan" , "hive" --===============1251886407570564740== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/973/ ----------------------------------------------------------- Review request for hive, Ashutosh Chauhan, Ning Zhang, and Amareshwari Srir= amadasu. Summary ------- * Removed alter database code from previous patch. * Updated create database to gracefully fail if database dir cannot be crea= ted (very close to Devaraj's patch) This addresses bug HIVE-1537. https://issues.apache.org/jira/browse/HIVE-1537 Diffs ----- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandle= r.java 1140495 = trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.j= ava 1140495 = trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java = 1140495 = trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaSto= re.java 1140495 = trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1140495 = trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.jav= a 1140495 = trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1140495 = trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.= java 1140495 = trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1= 140495 = trunk/ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 114049= 5 = trunk/ql/src/test/queries/clientpositive/database_location.q PRE-CREATION = trunk/ql/src/test/results/clientpositive/database_location.q.out PRE-CREA= TION = Diff: https://reviews.apache.org/r/973/diff Testing ------- Updated testDatabaseLocation() in TestHiveMetaStore() to test for negative = case. Ran entire unit test and it went through fine for me. Thanks, Thiruvel Thanks, Thiruvel --===============1251886407570564740==--