Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C94E9612D for ; Wed, 22 Jun 2011 23:18:40 +0000 (UTC) Received: (qmail 90190 invoked by uid 500); 22 Jun 2011 23:18:40 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 90158 invoked by uid 500); 22 Jun 2011 23:18:40 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 90137 invoked by uid 99); 22 Jun 2011 23:18:40 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jun 2011 23:18:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4226F1C002A; Wed, 22 Jun 2011 23:18:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2036657228092547548==" MIME-Version: 1.0 Subject: Re: Review Request: Review request for HIVE-2225 From: "John Sichi" To: "John Sichi" , "Carl Steinbach" Date: Wed, 22 Jun 2011 23:18:43 -0000 Message-ID: <20110622231843.14820.55199@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/940/ Cc: "hive" ,"Ashutosh Chauhan" In-Reply-To: <20110621173428.5108.10860@reviews.apache.org> References: <20110621173428.5108.10860@reviews.apache.org> --===============2036657228092547548== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/940/#review891 ----------------------------------------------------------- trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Why is this using a Thread instead of a Timer? trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/EventClean= erThread.java 6 hrs is actually configurable, right? - John On 2011-06-21 17:34:28, Ashutosh Chauhan wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/940/ > ----------------------------------------------------------- > = > (Updated 2011-06-21 17:34:28) > = > = > Review request for hive, Carl Steinbach and John Sichi. > = > = > Summary > ------- > = > This addresses HIVE-2225 > = > = > This addresses bug HIVE-2225. > https://issues.apache.org/jira/browse/HIVE-2225 > = > = > Diffs > ----- > = > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1138099 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore= .java 1138099 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.j= ava 1138099 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java= 1138099 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/EventC= leanerThread.java PRE-CREATION = > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkParti= tion.java 1138099 = > = > Diff: https://reviews.apache.org/r/940/diff > = > = > Testing > ------- > = > updated a test case which exercises this code path. > = > = > Thanks, > = > Ashutosh > = > --===============2036657228092547548==--