Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 283DC4CA4 for ; Tue, 21 Jun 2011 02:50:56 +0000 (UTC) Received: (qmail 7425 invoked by uid 500); 21 Jun 2011 02:50:55 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 7363 invoked by uid 500); 21 Jun 2011 02:50:55 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 7353 invoked by uid 99); 21 Jun 2011 02:50:55 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jun 2011 02:50:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F0071C0049; Tue, 21 Jun 2011 02:50:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6817271752055518236==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-872: Allow BIGINT constants From: "Syed Albiz" To: "John Sichi" Date: Tue, 21 Jun 2011 02:50:57 -0000 Message-ID: <20110621025057.5108.88705@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/889/ Cc: "Syed Albiz" ,"hive" In-Reply-To: <20110616023220.13641.51561@reviews.apache.org> References: <20110616023220.13641.51561@reviews.apache.org> --===============6817271752055518236== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/889/ ----------------------------------------------------------- (Updated 2011-06-21 02:50:57.581129) Review request for hive and John Sichi. Changes ------- Update test cases udf_coalesce.q and union2.q to check that type-widening i= s not applied incorrectly, use getCommonClassForComparison instead of getCo= mmonClass to compute type widening on union operator (fixing explode_null.q) Summary ------- Added a rule to the lexical grammar to allow BIGINT constants ending with '= L', and a clause to the TypeCheckProcFactory to ensure it gets interpreted = properly. This addresses bug HIVE-872. https://issues.apache.org/jira/browse/HIVE-872 Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 2462517 = ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ec816e9 = ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java= f46c16c = ql/src/test/queries/clientnegative/udf_coalesce.q 6d8da79 = ql/src/test/queries/clientnegative/union2.q 403d19d = ql/src/test/queries/clientpositive/type_widening.q PRE-CREATION = ql/src/test/results/clientnegative/udf_coalesce.q.out a4c3cab = ql/src/test/results/clientnegative/union2.q.out 16cfe03 = ql/src/test/results/clientpositive/type_widening.q.out PRE-CREATION = Diff: https://reviews.apache.org/r/889/diff Testing ------- TestCliDriver passes, previous behaviour was to accept bigint constants spe= cified without 'L', which is also preserved, so adding additional tests for= this case seems unnecessary. Thanks, Syed --===============6817271752055518236==--