Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D25A56FB5 for ; Mon, 13 Jun 2011 21:50:18 +0000 (UTC) Received: (qmail 40072 invoked by uid 500); 13 Jun 2011 21:50:18 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 40049 invoked by uid 500); 13 Jun 2011 21:50:18 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 40035 invoked by uid 99); 13 Jun 2011 21:50:18 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jun 2011 21:50:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8229A1C002A; Mon, 13 Jun 2011 21:50:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6783818681994098224==" MIME-Version: 1.0 Subject: Re: Review Request: HIVE-2215 From: "Ashutosh Chauhan" To: "John Sichi" Date: Mon, 13 Jun 2011 21:50:20 -0000 Message-ID: <20110613215020.13641.70858@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/883/ Cc: "Ashutosh Chauhan" ,"hive" In-Reply-To: <20110613214725.13641.25456@reviews.apache.org> References: <20110613214725.13641.25456@reviews.apache.org> --===============6783818681994098224== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2011-06-13 21:47:25, John Sichi wrote: > > trunk/metastore/src/model/package.jdo, line 670 > > > > > > Does indexing actually work on a LONGVARCHAR field across all DB's = of interest? No, it doesn't. So, I reverted it back to VARCHAR. If the rest of the patch looks alright, I will attach a new patch with this= change. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/883/#review822 ----------------------------------------------------------- On 2011-06-10 21:24:13, Ashutosh Chauhan wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/883/ > ----------------------------------------------------------- > = > (Updated 2011-06-10 21:24:13) > = > = > Review request for hive and John Sichi. > = > = > Summary > ------- > = > Follow-up for HIVE-2147. > = > = > This addresses bug HIVE-2215. > https://issues.apache.org/jira/browse/HIVE-2215 > = > = > Diffs > ----- > = > trunk/metastore/if/hive_metastore.thrift 1134443 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore= .java 1134443 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore= Client.java 1134443 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreCli= ent.java 1134443 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEven= tListener.java 1134443 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.j= ava 1134443 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java= 1134443 = > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/MarkPa= rtitionEvent.java PRE-CREATION = > trunk/metastore/src/model/org/apache/hadoop/hive/metastore/model/MParti= tionEvent.java PRE-CREATION = > trunk/metastore/src/model/package.jdo 1134443 = > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener= .java 1134443 = > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkParti= tionSet.java PRE-CREATION = > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStore= EventListener.java 1134443 = > = > Diff: https://reviews.apache.org/r/883/diff > = > = > Testing > ------- > = > Added test cases for new api. > = > = > Thanks, > = > Ashutosh > = > --===============6783818681994098224==--