Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 767EC6BE6 for ; Wed, 1 Jun 2011 07:52:09 +0000 (UTC) Received: (qmail 64840 invoked by uid 500); 1 Jun 2011 07:52:09 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 64520 invoked by uid 500); 1 Jun 2011 07:52:05 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 64504 invoked by uid 99); 1 Jun 2011 07:52:03 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 07:52:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 24EF71C0077; Wed, 1 Jun 2011 07:52:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0771569208995779232==" MIME-Version: 1.0 Subject: Re: Review Request: add exception handling to hive's record reader From: "Yongqiang He" To: "Ning Zhang" , "Yongqiang He" , "hive" Date: Wed, 01 Jun 2011 07:52:04 -0000 Message-ID: <20110601075204.27749.53359@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/812/ In-Reply-To: <20110601064814.5752.74335@reviews.apache.org> References: <20110601064814.5752.74335@reviews.apache.org> --===============0771569208995779232== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2011-06-01 06:48:14, Ning Zhang wrote: > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHa= ndlerUtil.java, line 57 > > > > > > Do you need to throw exception when all handler return false? ioExpectionHandlerChain will throw exception if all handler returns false. - Yongqiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/812/#review741 ----------------------------------------------------------- On 2011-06-01 00:38:42, Yongqiang He wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/812/ > ----------------------------------------------------------- > = > (Updated 2011-06-01 00:38:42) > = > = > Review request for hive. > = > = > Summary > ------- > = > add exception handling to hive's record reader > = > = > This addresses bug HIVE-2154. > https://issues.apache.org/jira/browse/HIVE-2154 > = > = > Diffs > ----- > = > trunk/conf/hive-default.xml 1129953 = > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordRead= er.java 1129953 = > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 112= 9953 = > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java 11= 29953 = > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.j= ava 1129953 = > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOpti= mizer.java 1129953 = > trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.ja= va 1129953 = > trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.= java 1129953 = > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHa= ndler.java PRE-CREATION = > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHa= ndlerChain.java PRE-CREATION = > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHa= ndlerUtil.java PRE-CREATION = > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNe= xtHandleResult.java PRE-CREATION = > = > Diff: https://reviews.apache.org/r/812/diff > = > = > Testing > ------- > = > = > Thanks, > = > Yongqiang > = > --===============0771569208995779232==--