Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8D85B4911 for ; Wed, 1 Jun 2011 00:38:42 +0000 (UTC) Received: (qmail 78529 invoked by uid 500); 1 Jun 2011 00:38:42 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 78406 invoked by uid 500); 1 Jun 2011 00:38:42 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 78396 invoked by uid 99); 1 Jun 2011 00:38:42 -0000 Received: from reviews.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 00:38:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E5BB51C0135; Wed, 1 Jun 2011 00:38:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6152714363358210650==" MIME-Version: 1.0 Subject: Re: Review Request: add exception handling to hive's record reader From: "Yongqiang He" To: "Ning Zhang" , "Yongqiang He" , "hive" Date: Wed, 01 Jun 2011 00:38:42 -0000 Message-ID: <20110601003842.27820.23678@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/812/ In-Reply-To: <20110531203123.27820.29792@reviews.apache.org> References: <20110531203123.27820.29792@reviews.apache.org> --===============6152714363358210650== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/812/ ----------------------------------------------------------- (Updated 2011-06-01 00:38:42.863958) Review request for hive. Changes ------- address Ning's comments to move some code to hadoopshims Summary ------- add exception handling to hive's record reader This addresses bug HIVE-2154. https://issues.apache.org/jira/browse/HIVE-2154 Diffs (updated) ----- trunk/conf/hive-default.xml 1129953 = trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader= .java 1129953 = trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 11299= 53 = trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java 1129= 953 = trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.jav= a 1129953 = trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimi= zer.java 1129953 = trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java= 1129953 = trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.ja= va 1129953 = trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHand= ler.java PRE-CREATION = trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHand= lerChain.java PRE-CREATION = trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHand= lerUtil.java PRE-CREATION = trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNext= HandleResult.java PRE-CREATION = Diff: https://reviews.apache.org/r/812/diff Testing ------- Thanks, Yongqiang --===============6152714363358210650==--