hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan" <hashut...@apache.org>
Subject Re: Review Request: Review request for HIVE-2225
Date Thu, 23 Jun 2011 02:55:28 GMT


> On 2011-06-22 23:07:46, John Sichi wrote:
> > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 221
> > <https://reviews.apache.org/r/940/diff/1/?file=21411#file21411line221>
> >
> >     If you agree about making this disabled by default, we could use a special value
such as 0 for the frequency to indicate disabled.
> >

Done. Timer is now created only if this property has non-zero value.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/940/#review889
-----------------------------------------------------------


On 2011-06-23 02:55:08, Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/940/
> -----------------------------------------------------------
> 
> (Updated 2011-06-23 02:55:08)
> 
> 
> Review request for hive, Carl Steinbach and John Sichi.
> 
> 
> Summary
> -------
> 
> This addresses HIVE-2225
> 
> 
> This addresses bug HIVE-2225.
>     https://issues.apache.org/jira/browse/HIVE-2225
> 
> 
> Diffs
> -----
> 
>   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1138719 
>   trunk/conf/hive-default.xml 1138719 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1138719

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1138719

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1138719 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/events/EventCleanerTask.java
PRE-CREATION 
>   trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartition.java 1138719

> 
> Diff: https://reviews.apache.org/r/940/diff
> 
> 
> Testing
> -------
> 
> updated a test case which exercises this code path.
> 
> 
> Thanks,
> 
> Ashutosh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message