hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Syed Albiz" <>
Subject Re: Review Request: HIVE-872: Allow BIGINT constants
Date Tue, 21 Jun 2011 02:50:57 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-06-21 02:50:57.581129)

Review request for hive and John Sichi.


Update test cases udf_coalesce.q and union2.q to check that type-widening is not applied incorrectly,
use getCommonClassForComparison instead of getCommonClass to compute type widening on union
operator (fixing explode_null.q)


Added a rule to the lexical grammar to allow BIGINT constants ending with 'L', and a clause
to the TypeCheckProcFactory to ensure it gets interpreted properly.

This addresses bug HIVE-872.

Diffs (updated)

  ql/src/java/org/apache/hadoop/hive/ql/exec/ 2462517 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ ec816e9 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/ f46c16c 
  ql/src/test/queries/clientnegative/udf_coalesce.q 6d8da79 
  ql/src/test/queries/clientnegative/union2.q 403d19d 
  ql/src/test/queries/clientpositive/type_widening.q PRE-CREATION 
  ql/src/test/results/clientnegative/udf_coalesce.q.out a4c3cab 
  ql/src/test/results/clientnegative/union2.q.out 16cfe03 
  ql/src/test/results/clientpositive/type_widening.q.out PRE-CREATION 



TestCliDriver passes, previous behaviour was to accept bigint constants specified without
'L', which is also preserved, so adding additional tests for this case seems unnecessary.



  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message