hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Krishna" <n_krishna_ku...@yahoo.com>
Subject Re: Review Request: Patch for Hive-2209, extending ObjectInspectorUtils.compare with some map comparison implementations
Date Fri, 17 Jun 2011 07:52:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/879/
-----------------------------------------------------------

(Updated 2011-06-17 07:52:38.058921)


Review request for hive and Yongqiang He.


Changes
-------

Added a complete compare implementation too, with sorting of the keys 


Summary
-------

Patch for HIVE-2209


Diffs (updated)
-----

  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/CrossMapEqualComparer.java
PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/FullMapEqualComparer.java PRE-CREATION

  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MapEqualComparer.java PRE-CREATION

  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 2b77072

  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SimpleMapEqualComparer.java
PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestCrossMapEqualcomparer.java
PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestFullMapEqualcomparer.java
PRE-CREATION 
  serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestSimpleMapEqualcomparer.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/879/diff


Testing
-------

Tests added


Thanks,

Krishna


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message