hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Syed Albiz" <s.s.al...@gmail.com>
Subject Re: Review Request: HIVE-872: Allow BIGINT constants
Date Wed, 15 Jun 2011 00:27:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/889/
-----------------------------------------------------------

(Updated 2011-06-15 00:27:01.842091)


Review request for hive and John Sichi.


Changes
-------

Gut the changes to TypeProcFactory and the grammer, instead amend COALESCE and UNION ALL to
allow type widening.


Summary
-------

Added a rule to the lexical grammar to allow BIGINT constants ending with 'L', and a clause
to the TypeCheckProcFactory to ensure it gets interpreted properly.


This addresses bug HIVE-872.
    https://issues.apache.org/jira/browse/HIVE-872


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 2462517 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ec816e9 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java f46c16c 
  ql/src/test/queries/clientpositive/type_widening.q PRE-CREATION 
  ql/src/test/results/clientpositive/type_widening.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/889/diff


Testing
-------

TestCliDriver passes, previous behaviour was to accept bigint constants specified without
'L', which is also preserved, so adding additional tests for this case seems unnecessary.


Thanks,

Syed


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message