hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sohan Jain" <sohanj...@fb.com>
Subject Re: Review Request: HIVE-2188: Add a function to retrieve multiple tables on trip to the hive metastore
Date Wed, 08 Jun 2011 02:53:32 GMT


> On 2011-06-07 20:09:34, Carl Steinbach wrote:
> > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java,
line 748
> > <https://reviews.apache.org/r/831/diff/3/?file=20654#file20654line748>
> >
> >     Sorry I missed this before, but you need to add a getTableObjectsByName() method
to IMetaStoreClient and HiveMetaStoreClient, and use that method here instead of calling client.client.get_table_objects_by_name().
Everything else looks good so, so you can either update this patch, or else open another ticket
to address this issue. Please let me know what you want to do. Thanks.

Hi Carl, I have updated the patch here.  Thanks for your help.


- Sohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/831/#review778
-----------------------------------------------------------


On 2011-06-07 01:11:44, Sohan Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/831/
> -----------------------------------------------------------
> 
> (Updated 2011-06-07 01:11:44)
> 
> 
> Review request for hive, Paul Yang and Ashutosh Chauhan.
> 
> 
> Summary
> -------
> 
> Created a function "multi_get_table" that retrieves multiple tables on one trip to the
hive metastore, saving round trip time.
> 
> 
> This addresses bug HIVE-2188.
>     https://issues.apache.org/jira/browse/HIVE-2188
> 
> 
> Diffs
> -----
> 
>   trunk/metastore/if/hive_metastore.thrift 1130342 
>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1130342

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1130342

>   trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1130342 
>   trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1130342

> 
> Diff: https://reviews.apache.org/r/831/diff
> 
> 
> Testing
> -------
> 
> Added a test case to testMetasore() in TestHiveServer.  Also tested for speed improvements
in a client session.
> 
> 
> Thanks,
> 
> Sohan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message